chore: remove snapshot testing from gapic-node-processing#7283
Closed
chore: remove snapshot testing from gapic-node-processing#7283
Conversation
Contributor
Author
|
I was able to get the unit tests passing on windows (which was a key motivator for this change). Now that they are passing, I don't think these snapshot tests are causing immediate harm. I am going to leave them for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discussed this issue with @sofisl and we agreed the snapshot tests are not adding enough value relative to the maintenance cost.
To that end, it seems appropriate to remove them. If we encounter a failure that these tests would have covered, we can add more focused tests.
Fixes #7282 🦕